lkml.org 
[lkml]   [2010]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v15 00/17] Provide a zero-copy method on KVM virtio-net.
From
From: xiaohui.xin@intel.com
Date: Tue, 9 Nov 2010 17:03:05 +0800

> We provide an zero-copy method which driver side may get external
> buffers to DMA. Here external means driver don't use kernel space
> to allocate skb buffers. Currently the external buffer can be from
> guest virtio-net driver.

1) Please use kernel-doc style comments to document structure
members.

2) The idea to key off of skb->dev in skb_release_data() is
fundamentally flawed since many actions can change skb->dev on you,
which will end up causing a leak of your external data areas.


\
 
 \ /
  Last update: 2010-11-09 18:17    [from the cache]
©2003-2011 Jasper Spaans