[lkml]   [2010]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH v15 00/17] Provide a zero-copy method on KVM virtio-net.
    Date: Tue, 9 Nov 2010 17:03:05 +0800

    > We provide an zero-copy method which driver side may get external
    > buffers to DMA. Here external means driver don't use kernel space
    > to allocate skb buffers. Currently the external buffer can be from
    > guest virtio-net driver.

    1) Please use kernel-doc style comments to document structure

    2) The idea to key off of skb->dev in skb_release_data() is
    fundamentally flawed since many actions can change skb->dev on you,
    which will end up causing a leak of your external data areas.

     \ /
      Last update: 2010-11-09 18:17    [W:0.019 / U:4.152 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site