Messages in this thread | | | Date | Mon, 8 Nov 2010 22:44:04 +0000 | From | Ralf Baechle <> | Subject | Re: [PATCH] MIPS VPE support module: don't deref potentially null pbuffer and don't do pointless null check before vfree |
| |
On Sun, Nov 07, 2010 at 07:48:25PM +0100, Jesper Juhl wrote:
> I've taken a second look. I still have no way at all to test this, so > please take a close look before potentially applying it, but how does this > look to you?
Testing is a little tricky - it requires a MIPS 34K processor in a configuration with more than one VPE.
> Don't dereference pbuffer before ttesting it for null. > Don't do pointless check of pointer passed to vfree for null as vfree does > this itself.
I've already checked in something based on your first patch with the other changes I suggested added.
Thanks!
Ralf
| |