Messages in this thread | | | From | Greg Thelen <> | Subject | Re: [patch 3/4] memcg: break out event counters from other stats | Date | Mon, 08 Nov 2010 15:20:38 -0800 |
| |
Minchan Kim <minchan.kim@gmail.com> writes:
> On Mon, Nov 8, 2010 at 7:14 AM, Johannes Weiner <hannes@cmpxchg.org> wrote: >> For increasing and decreasing per-cpu cgroup usage counters it makes >> sense to use signed types, as single per-cpu values might go negative >> during updates. But this is not the case for only-ever-increasing >> event counters. >> >> All the counters have been signed 64-bit so far, which was enough to >> count events even with the sign bit wasted. >> >> The next patch narrows the usage counters type (on 32-bit CPUs, that >> is), though, so break out the event counters and make them unsigned >> words as they should have been from the start. >> >> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org> > Reviewed-by: Minchan Kim <minchan.kim@gmail.com> Reviewed-by: Greg Thelen <gthelen@google.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |