Messages in this thread | | | Date | Mon, 08 Nov 2010 08:13:09 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] x86-64: more fixes and cleanup to AMD Fam10 MMCONF enabling |
| |
On 11/05/2010 03:59 AM, Jan Beulich wrote: > > --- 2.6.37-rc1-x86_64-mmconf-fam10h.orig/arch/x86/kernel/mmconf-fam10h_64.c > +++ 2.6.37-rc1-x86_64-mmconf-fam10h/arch/x86/kernel/mmconf-fam10h_64.c > @@ -43,7 +43,7 @@ static int __cpuinit cmp_range(const voi > return start1 - start2; > } > > -#define UNIT (1ULL << (5 + 3 + 12)) > +#define UNIT (1ULL << FAM10H_MMIO_CONF_BASE_SHIFT) > #define MASK (~(UNIT - 1)) > #define SIZE (UNIT << 8)
Could we avoid macros named UNIT, MASK, and SIZE at all? I realize they're already in the code, but still...
-hpa
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
| |