Messages in this thread | | | Date | Mon, 8 Nov 2010 09:41:14 -0500 | From | Don Zickus <> | Subject | Re: [PATCH] x86, hw_nmi: Move backtrace_mask declaration under ARCH_HAS_NMI_WATCHDOG. |
| |
On Sun, Nov 07, 2010 at 01:41:34PM +0600, Rakib Mullick wrote: > backtrace_mask has been used under the code context of > ARCH_HAS_NMI_WATCHDOG. So put it into that context. > We were warned by the following warning: > > arch/x86/kernel/apic/hw_nmi.c:21: warning: ‘backtrace_mask’ defined but not used
Thanks, I'll pull that into my tree.
Cheers, Don
> > > Signed-off-by: Rakib Mullick <rakib.mullick@gmail.com> > --- > > diff --git a/arch/x86/kernel/apic/hw_nmi.c b/arch/x86/kernel/apic/hw_nmi.c > index cefd694..62f6e1e 100644 > --- a/arch/x86/kernel/apic/hw_nmi.c > +++ b/arch/x86/kernel/apic/hw_nmi.c > @@ -17,15 +17,16 @@ > #include <linux/nmi.h> > #include <linux/module.h> > > -/* For reliability, we're prepared to waste bits here. */ > -static DECLARE_BITMAP(backtrace_mask, NR_CPUS) __read_mostly; > - > u64 hw_nmi_get_sample_period(void) > { > return (u64)(cpu_khz) * 1000 * 60; > } > > #ifdef ARCH_HAS_NMI_WATCHDOG > + > +/* For reliability, we're prepared to waste bits here. */ > +static DECLARE_BITMAP(backtrace_mask, NR_CPUS) __read_mostly; > + > void arch_trigger_all_cpu_backtrace(void) > { > int i; > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |