Messages in this thread | | | Date | Sun, 7 Nov 2010 20:00:09 +0100 | From | David Härdeman <> | Subject | Re: [PATCH] Fix Winbond CIR driver initialisation |
| |
On Sun, Nov 07, 2010 at 03:46:48PM +0000, Alan Cox wrote: > > A workaround is to boot with argument 8250.nr_uarts=1. This is not really > > desirable, so this patch makes ttyS1 go away. > > setserial can also be used for this surely ?
That's about as user-unfriendly as the boot option.
> > + dev_info(device, "Unregistering phony serial port ttyS1\n"); > > + serial8250_unregister_port(1); > > + ok = request_region(data->sbase, SP_IOMEM_LEN, DRVNAME); > > That's a hack that is only going to work on specific systems where it is > mapped the way you expect and doing stuff behind the back of the serial > driver. > > I'm not averse to a better solution but it needs to be general and > maintainable. Is there a way to identify the presence of the windbond CIR > device as opposed to an 8250 ?
Not sure which kind of identification you're looking for but would a PNP id be sufficient?
-- David Härdeman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |