Messages in this thread | | | Date | Sat, 06 Nov 2010 15:59:51 +0100 | From | Marco Stornelli <> | Subject | Re: [PATCH 02/16 v2] pramfs: super block operations |
| |
Il 06/11/2010 12:16, James Hogan ha scritto: > Hi Marco, > > On Sat, Nov 06, 2010 at 09:56:39AM +0100, Marco Stornelli wrote: >> From: Marco Stornelli <marco.stornelli@gmail.com> >> +static void pram_set_blocksize(struct super_block *sb, unsigned long size) >> +{ >> + int bits; >> + >> + /* >> + * We've already validated the user input and the value here must be >> + * between PRAM_MAX_BLOCK_SIZE and PRAM_MIN_BLOCK_SIZE >> + * and it must be a power of 2. >> + */ > > Should this comment have spaces after the tabs to be consistent with the > other multiline comments (pram_ioremap) and the coding style? >
Ok, no problem.
Thanks for the review.
Regards,
Marco
| |