lkml.org 
[lkml]   [2010]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] kernel/range: Fix clean_sort_range for the case of full array
clean_sort_range() should return a number of nonempty elements of range 
array, but if the array is full clean_sort_range() returns 0.

The problem is that the number of nonempty elements is evaluated by
finding the first empty element of the array. If there is no such
element it returns an initial value of local variable nr_range that is zero.

The fix is trivial: it changes initial value of nr_range to size of the
array.

The bug can lead to loss of information regarding all ranges, since
typically returned value of clean_sort_range() is considered as an
actual number of ranges in the array after a series of add/subtract
operations.


Found by Analytical Verification project of Linux Verification Center
(linuxtesting.org), thanks to Alexander Kolosov.


Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---

diff --git a/kernel/range.c b/kernel/range.c
index 471b66a..37fa9b9 100644
--- a/kernel/range.c
+++ b/kernel/range.c
@@ -119,7 +119,7 @@ static int cmp_range(const void *x1, const void *x2)

int clean_sort_range(struct range *range, int az)
{
- int i, j, k = az - 1, nr_range = 0;
+ int i, j, k = az - 1, nr_range = az;

for (i = 0; i < k; i++) {
if (range[i].end)


\
 
 \ /
  Last update: 2010-11-06 00:27    [W:0.022 / U:1.680 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site