Messages in this thread | | | From | Milton Miller <> | Subject | Re: [PATCH 1/1] PCI: xen-pcifront, fix PCI reference leak | Date | Thu, 04 Nov 2010 12:27:07 -0600 |
| |
On 2010-11-04 at about 14:31:30 Jiri Slaby wrote: > Stanse found that when pdev is found and has no driver a reference is > leaked in pcifront_common_process. So add pci_dev_put there. For the > pdev == NULL case, pci_dev_put(NULL) is fine.
While that may be true, the dev_err(&pcidev->dev ... is a NULL pointer deref.
> > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > Cc: Jesse Barnes <jbarnes@virtuousgeek.org> > --- > drivers/pci/xen-pcifront.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c > index a87c498..f9ffc05 100644 > --- a/drivers/pci/xen-pcifront.c > +++ b/drivers/pci/xen-pcifront.c > @@ -578,6 +578,7 @@ static pci_ers_result_t pcifront_common_process(int cmd, > if (!pcidev || !pcidev->driver) { > dev_err(&pcidev->dev, > "device or driver is NULL\n"); > + pci_dev_put(pcidev); > return result; > } > pdrv = pcidev->driver; >
milton
| |