Messages in this thread | | | Date | Thu, 4 Nov 2010 04:31:08 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCHv1] staging: Synaptics RMI4 touchpad driver support |
| |
Hi Arce,
On Thu, Nov 04, 2010 at 12:45:45AM -0500, Arce, Abraham wrote: > Hi Naveen, Dmitry, > > > From: Naveen Kumar GADDIPATI [mailto:naveen.gaddipati@stericsson.com] > > > > Hi Arce, > > > > I'm also the GPIO pin for interrupt with request threaded irq . > > I'm passing the irq_type from the platform data. > > Which irq_type are you using for your platform? > > > > I am using the following flags > > IRQF_DISABLED | IRQF_TRIGGER_LOW | IRQF_TRIGGER_FALLING > > Should I get rid of the first one, IRQF_DISABLED? > > IRQF_DISABLED - keep irqs disabled when calling the action handler >
You probably want IRQF_TRIGGER_LOW | IRQF_ONESHOT if your interrupt is level tiggered.
IRQF_TRIGGER_LOW | IRQF_TRIGGER_FALLING mixes edge and level options and thus I don't think is proper.
-- Dmitry
| |