[lkml]   [2010]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 2/2] exec: copy-and-paste the fixes into compat_do_execve() paths
    > Note: this patch targets 2.6.37 and tries to be as simple as possible.
    > That is why it adds more copy-and-paste horror into fs/compat.c and
    > uglifies fs/exec.c, this will be cleanuped later.
    > compat_copy_strings() plays with bprm->vma/mm directly and thus has
    > two problems: it lacks the RLIMIT_STACK check and argv/envp memory
    > is not visible to oom killer.
    > Export acct_arg_size() and get_arg_page(), change compat_copy_strings()
    > to use get_arg_page(), change compat_do_execve() to do acct_arg_size(0)
    > as do_execve() does.
    > Add the fatal_signal_pending/cond_resched checks into compat_count() and
    > compat_copy_strings(), this matches the code in fs/exec.c and certainly
    > makes sense.
    > Signed-off-by: Oleg Nesterov <>

    Looks good to me.
    Reviewed-by: KOSAKI Motohiro <>

     \ /
      Last update: 2010-12-01 04:07    [W:0.020 / U:0.340 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site