lkml.org 
[lkml]   [2010]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/8] ARM: VExpress: Switch to generic SCU routines
    On Tue, Nov 30, 2010 at 08:17:01PM +0300, Anton Vorontsov wrote:
    > +/* If there are more than one CPU let them know where to start. */
    > +static void __init smp_point_cpus(void)
    > +{
    > + if (num_present_cpus() <= 1)
    > + return;
    >
    > - for (i = 0; i < ncores; i++)
    > - set_cpu_possible(i, true);
    > + writel(~0, MMIO_P2V(V2M_SYS_FLAGSCLR));
    > + writel(BSYM(virt_to_phys(scu_secondary_startup)),
    > + MMIO_P2V(V2M_SYS_FLAGSSET));
    > }

    I don't see the point of separating this code from the code below. It
    doesn't seem to bring any benefit. Could you explain why it's necessary
    to separate this?

    > void __init smp_prepare_cpus(unsigned int max_cpus)
    > {
    ...


    \
     
     \ /
      Last update: 2010-12-01 00:29    [W:0.019 / U:28.484 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site