[lkml]   [2010]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [2/8, v5] NUMA Hotplug Emulator: Add node hotplug emulation
On Tue, 30 Nov 2010, Shaohui Zheng wrote:

> We have two memory hotplug interfaces here:
> add_node: add a new NUMA node
> probe: add memory section
> so puting add_node to node/add_node and puting probe to memory/probe should make sense.
> it is similar with sysfs hierarchy.
> if we want to move the add_node to mem_hotplug/add_node, I'd prefer to put the probe
> interface to mem_hotplug/probe since they are also related to memory hotplug.
> I will include this change in next patchset.

No, please don't move the 'probe' trigger to debugfs; hotadding memory
should not depend on CONFIG_DEBUG_FS. Node hotplug emulation _is_ a
debugging function and can therefore be defined in debugfs as I did but
with a s/hotplug/mem_hotplug change that Greg suggested.

 \ /
  Last update: 2010-11-30 21:13    [W:0.075 / U:1.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site