Messages in this thread | | | Date | Tue, 30 Nov 2010 20:22:23 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH] kernel/time: Make /proc/timer_list mode 0400 |
| |
Hi!
> > > > iirc powertop parses this.. > > > > > > I bet it doesn't look at the kernel address (why was that added in the > > > first place, anyway?) > > > > > > I'd suggest that the risk of breakage would be much less if we left the > > > file permissions alone and arranged for those addresses to be > > > 0000000000000000 for non-root readers. > > > > You beat me to it. Having the full information is quite helpful at > > times. > > We should do something like: > > if (!capable(CAP_SYS_ADMIN)) > print_ptr = NULL; > > sprintf(s, "%p", print_ptr);
Having single file that contains different stuff based on capable() is very very ugly. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |