lkml.org 
[lkml]   [2010]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] ARM: imx: Add mx53 support to common msl functions.
Hi Dinh,

Le 02/11/2010 23:17, Dinh.Nguyen@freescale.com a écrit :
> From: Dinh Nguyen<Dinh.Nguyen@freescale.com>
>
> Add mx53 support to cpu.c and mm.c.
>
> Signed-off by: Dinh Nguyen<Dinh.Nguyen@freescale.com>
> static void query_silicon_parameter(void)
> {
> - void __iomem *rom = ioremap(MX51_IROM_BASE_ADDR, MX51_IROM_SIZE);
> + void __iomem *rom;
> u32 rev;
>
> + if (cpu_is_mx51())
> + rom = ioremap(MX51_IROM_BASE_ADDR, MX51_IROM_SIZE);
> + else if (cpu_is_mx53())
> + rom = ioremap(MX53_IROM_BASE_ADDR, MX53_IROM_SIZE);
> +
isn't the correct way to get the silicon revision to read the "Product
Revision register" and "Silicon Revision register" of the IIM and not from the
internal ROM ? (page 41-11 of the i.MX51 reference manual).

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-11-03 10:19    [W:0.057 / U:0.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site