Messages in this thread | | | Date | Wed, 3 Nov 2010 11:10:28 -0500 (CDT) | From | Christoph Lameter <> | Subject | Re: [PATCH] cgroup: Avoid a memset by using vzalloc |
| |
On Wed, 3 Nov 2010, Joe Perches wrote:
> On Wed, 2010-11-03 at 23:20 +0800, jovi zhang wrote: > > On Wed, Nov 3, 2010 at 10:38 PM, Christoph Lameter <cl@linux.com> wrote: > > > On Mon, 1 Nov 2010, Jesper Juhl wrote: > > > > > >> On Sun, 31 Oct 2010, Balbir Singh wrote: > > > > > >> > > There are so many placed need vzalloc. > > >> > > Thanks, Jesper. > > > > > > > > > Could we avoid this painful exercise with a "semantic patch"? > > There's an existing cocci kmalloc/memset script.
I have it in /usr/share/doc/coccinelle/examples/janitorings/kzalloc-orig.cocci.gz
(Ubuntu coccinelle package)
> Perhaps this is good enough? > > cp scripts/coccinelle/api/alloc/kzalloc-simple.cocci scripts/coccinelle/api/alloc/vzalloc-simple.cocci > sed -i -e 's/kmalloc/vmalloc/g' -e 's/kzalloc/vzalloc/g' scripts/coccinelle/api/alloc/vzalloc-simple.cocci
Not sure if that is the same script but certainly a good start. Try it and see if it catches all the locations that you know of?
| |