Messages in this thread | | | Subject | Re: [PATCH] regulator: Staticise mc13783_powermisc_rmw() | From | Alberto Panizzo <> | Date | Wed, 03 Nov 2010 14:50:08 +0100 |
| |
On mer, 2010-11-03 at 00:08 -0400, Mark Brown wrote: > It is not used outside this driver so no need to make the symbol global. > > Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
It's OK for me, because no other functionalities than regulator's one are influenced by the Power Misc register.
Acked-by: Alberto Panizzo <maramaopercheseimorto@gmail.com>
> --- > drivers/regulator/mc13783-regulator.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/regulator/mc13783-regulator.c b/drivers/regulator/mc13783-regulator.c > index 5e6fa47..47ea999 100644 > --- a/drivers/regulator/mc13783-regulator.c > +++ b/drivers/regulator/mc13783-regulator.c > @@ -471,8 +471,8 @@ static struct regulator_ops mc13783_fixed_regulator_ops = { > .get_voltage = mc13783_fixed_regulator_get_voltage, > }; > > -int mc13783_powermisc_rmw(struct mc13783_regulator_priv *priv, u32 mask, > - u32 val) > +static int mc13783_powermisc_rmw(struct mc13783_regulator_priv *priv, u32 mask, > + u32 val) > { > struct mc13783 *mc13783 = priv->mc13783; > int ret;
-- Alberto!
Be Persistent! - Greg Kroah-Hartman (FOSDEM 2010)
| |