lkml.org 
[lkml]   [2010]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -tip] sched: fix uninitialized variable usage
From
Date
On Tue, 2010-11-30 at 11:54 +0800, Paul Turner wrote:
> On Mon, Nov 29, 2010 at 7:51 PM, Lin Ming <ming.m.lin@intel.com> wrote:
> > linux-2.6/kernel/sched.c: In function ‘sched_destroy_group’:
> > linux-2.6/kernel/sched.c:8101: warning: ‘i’ is used uninitialized in this function
> >
> > This is caused by commit 3d4b47b(Implement on-demand (active) cfs_rq list)
> >
> > Signed-off-by: Lin Ming <ming.m.lin@intel.com>
> > ---
> > kernel/sched.c | 3 +--
> > 1 files changed, 1 insertions(+), 2 deletions(-)
> >
>
> Thanks for the catch!
>
> http://lkml.org/lkml/2010/11/29/566 -- should already address this

OK :)

Thanks.

>
> - Paul
>
>
> > diff --git a/kernel/sched.c b/kernel/sched.c
> > index 717bf7d..c3af198 100644
> > --- a/kernel/sched.c
> > +++ b/kernel/sched.c
> > @@ -8088,7 +8088,6 @@ static inline void unregister_fair_sched_group(struct task_group *tg, int cpu)
> > {
> > struct rq *rq = cpu_rq(cpu);
> > unsigned long flags;
> > - int i;
> >
> > /*
> > * Only empty task groups can be destroyed; so we can speculatively
> > @@ -8098,7 +8097,7 @@ static inline void unregister_fair_sched_group(struct task_group *tg, int cpu)
> > return;
> >
> > raw_spin_lock_irqsave(&rq->lock, flags);
> > - list_del_leaf_cfs_rq(tg->cfs_rq[i]);
> > + list_del_leaf_cfs_rq(tg->cfs_rq[cpu]);
> > raw_spin_unlock_irqrestore(&rq->lock, flags);
> > }
> > #else /* !CONFG_FAIR_GROUP_SCHED */
> >
> >
> >


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-11-30 05:29    [W:0.031 / U:1.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site