lkml.org 
[lkml]   [2010]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [8/8, v5] NUMA Hotplug Emulator: documentation
On Mon, Nov 29, 2010 at 01:19:16PM -0500, Valdis.Kletnieks@vt.edu wrote:
> On Mon, 29 Nov 2010 17:17:58 +0800, shaohui.zheng@intel.com said:
> > From: Shaohui Zheng <shaohui.zheng@intel.com>
> >
> > add a text file Documentation/x86/x86_64/numa_hotplug_emulator.txt
> > to explain the usage for the hotplug emulator.
>
> Can you renumber this to 1/8 if you resubmit it? It helps code review if you
> already know what it's *intended* to do beforehand. It also helps drinking
> from the lkml firehose if you can read 0/N and 1/N and know if it's something
> you want to review, otherwise you read 0/N, have to go find N/N, read that,
> then go back and delete 1/N through N-1/N.
>
> (Sometimes, the 0/N cover isn't enough - reading the documentation actually
> fills in enough blanks to make you go "Wow, this *is* applicable to something
> I'm working on...")

When I send the previous version, I always add the full documentation in 0/N
patches. The feedbacks, suggestions, and modifications are all included in 0/N
patch. it makes it as a very long text, so I decide to remove the full documentation
from 0/N since we already send these docs in early version, it get the 0/N patch
much smaller.

I will still keep the full documentation in 0/N, and renumber 8/8 to 1/8. Thanks
for the remind.


--
Thanks & Regards,
Shaohui



\
 
 \ /
  Last update: 2010-11-30 03:57    [W:0.033 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site