lkml.org 
[lkml]   [2010]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] arm: plat-omap: counter_32k: use IS_ERR() instead of NULL check
Date
Vasiliy Kulikov <segoon@openwall.com> writes:

> clk_get() returns ERR_PTR() on error, not NULL.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>

Acked-by: Kevin Hilman <khilman@deeprootsystems.com>

> ---
> Cannot compile this driver, so it is not tested at all.
>
> arch/arm/plat-omap/counter_32k.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/counter_32k.c b/arch/arm/plat-omap/counter_32k.c
> index 155fe43..c1e0d00 100644
> --- a/arch/arm/plat-omap/counter_32k.c
> +++ b/arch/arm/plat-omap/counter_32k.c
> @@ -164,7 +164,7 @@ static int __init omap_init_clocksource_32k(void)
> return -ENODEV;
>
> sync_32k_ick = clk_get(NULL, "omap_32ksync_ick");
> - if (sync_32k_ick)
> + if (!IS_ERR(sync_32k_ick))
> clk_enable(sync_32k_ick);
>
> clocksource_32k.mult = clocksource_hz2mult(32768,


\
 
 \ /
  Last update: 2010-11-29 16:31    [W:0.031 / U:15.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site