lkml.org 
[lkml]   [2010]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] arm: plat-spear: time: use IS_ERR() instead of NULL check
From
On Fri, Nov 26, 2010 at 10:36 PM, Vasiliy Kulikov <segoon@openwall.com> wrote:
> clk_get() returns ERR_PTR() on error, not NULL.
>
> Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
> ---
>  Cannot compile this driver, so it is not tested at all.
>
>  arch/arm/plat-spear/time.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/plat-spear/time.c b/arch/arm/plat-spear/time.c
> index ab21165..678df18 100644
> --- a/arch/arm/plat-spear/time.c
> +++ b/arch/arm/plat-spear/time.c
> @@ -229,13 +229,13 @@ void __init spear_setup_timer(void)
>        }
>
>        gpt_clk = clk_get_sys("gpt0", NULL);
> -       if (!gpt_clk) {
> +       if (IS_ERR(gpt_clk)) {
>                pr_err("%s:couldn't get clk for gpt\n", __func__);
>                goto err_iomap;
>        }
>
>        pll3_clk = clk_get(NULL, "pll3_48m_clk");
> -       if (!pll3_clk) {
> +       if (IS_ERR(pll3_clk)) {
>                pr_err("%s:couldn't get PLL3 as parent for gpt\n", __func__);
>                goto err_iomap;
>        }

Compiled & tested.

Acked-by: Viresh Kumar <viresh.kumar@st.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-11-29 07:35    [W:0.030 / U:1.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site