[lkml]   [2010]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 4/4] input: mt: Add pressure to pointer emulation code
>> @@ -124,9 +125,13 @@ void input_mt_report_pointer_emulation(struct input_dev

>> if (oldest) {
>> int x = input_mt_get_value(oldest, ABS_MT_POSITION_X);
>> int y = input_mt_get_value(oldest, ABS_MT_POSITION_Y);
>> + int p = input_mt_get_value(oldest, ABS_MT_PRESSURE);
> What if device does not report ABS_MT_PRESSURE/ABS_PRESSURE? Do we rely
> on input core to suppress unsupported events? A comment would be nice...

Yes, the setup values are the only ones producing output here. How about this
addition to the function text: "The input core ensures only the KEY and ABS axes
already setup for this device will produce output."?

> Also, is there a gelper to set up pointer emulation capabilities for MT
> device?

This is certainly the plan with time, but currently it seemed best to leave the
rest of the event setup code untouched.


 \ /
  Last update: 2010-11-29 12:23    [W:0.040 / U:7.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site