lkml.org 
[lkml]   [2010]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2] add netdev led trigger
    Date
    Eric Cooper <ecc@cmu.edu> writes:

    > Add a netdev LED trigger for all Blinkenlights lovers...
    > Originally taken from https://dev.openwrt.org/ticket/2776
    > Slightly updated for 2.6.24 by Mickey Lauer <mickey@openmoko.org>
    > and for 2.6.36 by Eric Cooper <ecc@cmu.edu>

    You should really send this to netdev too.

    Some comments:

    The timer seems power unfriendly -- it will always tick even if nothing
    happens.

    Using the device name as an identifier is not reliable, they may
    not be unique.

    rwlocks are deprecated.

    your store code has a off by one I think, it's possible to put
    not 0 terminated data in the string.


    -Andi

    --
    ak@linux.intel.com -- Speaking for myself only.


    \
     
     \ /
      Last update: 2010-11-29 11:19    [W:0.019 / U:122.052 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site