[lkml]   [2010]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] add netdev led trigger
Eric Cooper <> writes:

> Add a netdev LED trigger for all Blinkenlights lovers...
> Originally taken from
> Slightly updated for 2.6.24 by Mickey Lauer <>
> and for 2.6.36 by Eric Cooper <>

You should really send this to netdev too.

Some comments:

The timer seems power unfriendly -- it will always tick even if nothing

Using the device name as an identifier is not reliable, they may
not be unique.

rwlocks are deprecated.

your store code has a off by one I think, it's possible to put
not 0 terminated data in the string.


-- -- Speaking for myself only.

 \ /
  Last update: 2010-11-29 11:19    [W:0.038 / U:0.296 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site