Messages in this thread Patch in this message | | | Date | Sat, 27 Nov 2010 14:01:20 +0100 | Subject | Re: [PATCH] ARM: Gemini: Add support for PCI Bus | From | Michał Mirosław <> |
| |
W dniu 27 listopada 2010 13:16 użytkownik Hans Ulli Kroll <ulli.kroll@googlemail.com> napisał: > On Fri, 26 Nov 2010, Michał Mirosław wrote: >> 2010/11/20 Hans Ulli Kroll <ulli.kroll@googlemail.com>: >> > Add support for PCI Bus on Gemini Devices SL3516 >> > >> > Signed-off-by: Hans Ulli Kroll <ulli.kroll@googlemail.com> >> > --- >> [...] >> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >> > index a19a526..5d4b398 100644 >> > --- a/arch/arm/Kconfig >> > +++ b/arch/arm/Kconfig >> > @@ -307,6 +307,7 @@ config ARCH_GEMINI >> > select CPU_FA526 >> > select ARCH_REQUIRE_GPIOLIB >> > select ARCH_USES_GETTIMEOFFSET >> > + select PCI >> > help >> > Support for the Cortina Systems Gemini family SoCs >> > >> [...] >> I think it's better to add ARCH_GEMINI to CONFIG_PCI dependencies. >> AFAIK IB-4220B NAS does not use PCI and doesn't need all that code. >> Board support entries could select PCI if the board is useless without >> it. > I know this, I have some. > > There are many boards with PCI i.e WBD 222. > Other ARM devices uses the same select inside ARCH_* > I don't want to pollute drivers/pci/Kconfig.
I meant 'config PCI' entry in arch/arm/Kconfig, see following diff.
Best Regards, Michał Mirosław
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index db524e7..74ea522 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -1164,7 +1164,7 @@ config ISA_DMA_API bool
config PCI - bool "PCI support" if ARCH_INTEGRATOR_AP || ARCH_VERSATILE_PB || ARCH_IXP4XX || ARCH_KS8695 || MACH_ARMCORE || ARCH_CNS3XXX + bool "PCI support" if ARCH_INTEGRATOR_AP || ARCH_VERSATILE_PB || ARCH_IXP4XX || ARCH_KS8695 || MACH_ARMCORE || ARCH_CNS3XXX || ARCH_GEMINI help Find out whether you have a PCI motherboard. PCI is the name of a bus system, i.e. the way the CPU talks to the other stuff inside -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |