lkml.org 
[lkml]   [2010]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RESEND][BUG][PATCH]-rc: USB: yurex: add .llseek fop to file_operations
    Date
    On Thursday 25 November 2010 18:16:13 Greg KH wrote:
    > On Fri, Nov 26, 2010 at 01:11:05AM +0900, Tomoki Sekiyama wrote:
    > > Hi Greg-KH,
    > > Sorry for resending this; To: was not enough.
    > >
    > > https://bugzilla.kernel.org/show_bug.cgi?id=23512
    > >
    > > Default llseek operation behavior was changed by the patch named
    > > "vfs: make no_llseek the default" after the yurex driver was merged,
    > > so the llseek to yurex is now ignored.
    > >
    > > This patch add llseek fop with default_llseek to yurex driver
    > > to catch up to the change.
    > >
    > > Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@gmail.com>
    >
    > It's in my queue, sorry, been without power and water at home for a few
    > days, will catch up on this stuff next week...

    I was out most of the week, so I didn't get to look at it either.
    Is there an actual bug here caused by having no .llseek function?

    As far as I can tell, you don't really want to seek this file
    anyway, so the default behaviour of disallowing llseek would actually
    make more sense.

    Arnd


    \
     
     \ /
      Last update: 2010-11-26 16:25    [W:3.098 / U:0.612 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site