Messages in this thread | | | From | Grant Likely <> | Date | Wed, 24 Nov 2010 21:10:36 -0700 | Subject | Re: How do I choose an arbitrary minor number for my tty device? |
| |
On Wed, Nov 24, 2010 at 3:46 PM, Michael Ellerman <michael@ellerman.id.au> wrote: > On Wed, 2010-11-24 at 12:08 -0600, Scott Wood wrote: >> On Wed, 24 Nov 2010 21:23:47 +1100 >> Michael Ellerman <michael@ellerman.id.au> wrote: > >> > > It would be nice if platform devices that are created from device tree >> > > nodes included a link to the corresponding /proc/device-tree node in >> > > their sysfs node. >> > >> > It's not a link, but the OF path is in devspec, so you can work it out >> > fairly easily. >> >> Hmm, I see a "devspec" in PCI devices, but not in devtree-probed >> platform devices. of_bus_type_init isn't being called from anywhere >> but the ibmebus code. It looks like this was a casualty of merging >> of_platform with platform (commit eca3930163ba8884060ce9d9ff5ef0d9b7c7b00f). > > Ah crud, yeah I was looking at an old kernel. > > That seems like a regression, but seemingly no one has complained so > perhaps it doesn't matter in practice. It was certainly a nice feature > though.
Hmmm, I missed that when merging. Oops.
devspec is easy enough to add back since there isn't a conflict. It can even be made system-wide (not just platform bus) since any device can have an of_node now. However, the modalias and name attributes are a lot harder since there are name conflicts.
g.
-- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |