lkml.org 
[lkml]   [2010]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: rcu_read_lock/unlock protect find_task_by_vpid call in migrate_pages
Date
Hi

> Signed-off-by: Dave Jones <davej@redhat.com>
>
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 4a57f13..2f0f55b 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -1308,6 +1308,7 @@ SYSCALL_DEFINE4(migrate_pages, pid_t, pid, unsigned long, maxnode,
>
> /* Find the mm_struct */
> read_lock(&tasklist_lock);
> + rcu_read_lock();
> task = pid ? find_task_by_vpid(pid) : current;
> if (!task) {
> read_unlock(&tasklist_lock);
> @@ -1315,6 +1316,7 @@ SYSCALL_DEFINE4(migrate_pages, pid_t, pid, unsigned long, maxnode,
> goto out;
> }
> mm = get_task_mm(task);
> + rcu_read_unlock();
> read_unlock(&tasklist_lock);
>
> err = -EINVAL;

Thanks reporting. but mmotm seems already has the same patch.





\
 
 \ /
  Last update: 2010-11-25 01:53    [W:0.057 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site