lkml.org 
[lkml]   [2010]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: ldisc problems with 2.6.32-2.6.37-rc2 (at least)
    On 11/24/2010 10:53 PM, Sergey Lapin wrote:
    > Initially I run it, everything is ok.
    > Then I run it and get error and backtrace.
    > And if I run it again, everything is ok again, repeatedly. Probably some resources are properly
    > set up in error condition, and not in normal condition.
    >
    > I use ARM machine for testing and x86, bug is architecture-independent.
    >
    > addr2lines:
    > c01bc110 drivers/tty/tty_ldisc.c:499

    Got it. Does this fixes the warning?
    --- a/drivers/tty/tty_ldisc.c
    +++ b/drivers/tty/tty_ldisc.c
    @@ -454,6 +454,8 @@ static int tty_ldisc_open(struct tty_struct *tty,
    struct tty_ldisc *ld)
    /* BTM here locks versus a hangup event */
    WARN_ON(!tty_locked());
    ret = ld->ops->open(tty);
    + if (ret)
    + clear_bit(TTY_LDISC_OPEN, &tty->flags);
    return ret;
    }
    return 0;
    thanks,
    --
    js
    suse labs


    \
     
     \ /
      Last update: 2010-11-24 23:05    [W:0.024 / U:86.856 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site