lkml.org 
[lkml]   [2010]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next-2.6 8/17 v3] can: EG20T PCH: Change Copyright and module description
From
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Wed, 24 Nov 2010 14:35:44 +0100

> On 11/24/2010 01:19 PM, Tomoya MORINAGA wrote:
>> Currently, Copyright and module description are not formal.
>
> As David pointed out in an older version of this series, this patch does
> more than the subject indicates. Please fix.

Many patches still have this problem.

I'm getting really upset about this.

Look, it's simple. Make sure your patch commit message describes
everything the patch is doing.

And in many of the cases where the commit message is not accurate, it
is actually the cases that the changes not documented are totally
unrelated and need to be split up into a different change.

I strongly suspect that the pch_can folks became extremely frustrated
doing these patch split-ups. They find them pointless and they feel
that we're putting an unnecessary burdon upon them, and are having
trouble understanding why we require this and why it's so incredibly
important.

So they worked on this task with the most minimum of effort and care,
which is extremely unfortunate.

We will continue to push back until they get things correct, so all
they do by being lazy and careless is make more work for everyone,
including themselves.


\
 
 \ /
  Last update: 2010-11-24 18:09    [W:0.038 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site