lkml.org 
[lkml]   [2010]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 0/3] jump label: updates for 2.6.37
    From
    Date
    On Wed, 2010-11-24 at 09:29 +0100, Peter Zijlstra wrote:
    > On Tue, 2010-11-23 at 18:10 -0500, Steven Rostedt wrote:
    >
    > > Anyway, I just tried what you explained with the current kernel, with
    > > and without jump labels and, without jump labels, the module has its
    > > kmalloc tracepoint traced, but with jump labels it does not. So we can
    > > treat this as a regression, which is something that can go into an -rc.
    > >
    > > The change log must state that this _is_ a regression, or Linus may not
    > > accept it.
    >
    > I really dislike the first patch... Preferably I'd simply fully revert
    > all the jump-label stuff and try again next round with a saner
    > interface.

    Well, it is configurable and default off. Lets leave it as is for 37
    then, and we can rework it for 38.

    >
    > There's a really good simple fix for this, simply disable the gcc
    > trickery for .37 and use the fallback.

    Again, its default off. Unless you specifically enable it, it does the
    old style tracepoints.

    >
    > Then for .38, mandate the key type to be atomic_t * and switch to the
    > SWITCH_POINT() interface from hpa.

    I agree about the SWITCH_POINT() type interface, but I'm still not sure
    about forcing atomic_t. I'll have to think about that one.

    -- Steve




    \
     
     \ /
      Last update: 2010-11-24 13:49    [W:0.019 / U:120.164 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site