Messages in this thread | | | Subject | Re: [PATCH v2 08/20] ARM: LPAE: MMU setup for the 3-level page table format | From | Catalin Marinas <> | Date | Tue, 23 Nov 2010 17:35:29 +0000 |
| |
On Tue, 2010-11-23 at 17:33 +0000, Russell King - ARM Linux wrote: > On Tue, Nov 23, 2010 at 11:38:15AM +0000, Catalin Marinas wrote: > > On 22 November 2010 13:10, Russell King - ARM Linux > > <linux@arm.linux.org.uk> wrote: > > > Are you sure these shifts by 18 places are correct? They're actually > > > (val >> SECTION_SHIFT) << 2, so maybe they should be (SECTION_SHIFT - > > > PMD_WORDS) ? > > > > SECTION_SHIFT - PMD_ORDER is (20 - 2) for classic page tables and (21 > > - 3) for LPAE. But we could change the 18 to some macros for > > clarification (the line would be long though). > > So yes, it's SECTION_SHIFT - PMD_ORDER, which is how they should be > used IMHO. I don't see why another macro would be necessary.
I didn't mean adding another macro but using (SECTION_SHIFT - PMD_ORDER) on a long line.
-- Catalin
| |