Messages in this thread | | | From | Mike Frysinger <> | Date | Mon, 22 Nov 2010 20:27:28 -0500 | Subject | Re: [PATCH] romfs: have romfs_fs.h pull in necessary headers |
| |
On Mon, Nov 22, 2010 at 19:43, Andrew Morton wrote: > On Mon, 22 Nov 2010 19:40:16 -0500 Mike Frysinger wrote: >> On Mon, Nov 22, 2010 at 16:58, Andrew Morton wrote: >> > On Sun, 21 Nov 2010 19:24:21 -0500 Mike Frysinger wrote: >> >> This header uses things like __be32, so pull in linux/types.h. >> >> >> >> Further, it uses BLOCK_SIZE, so pull in linux/fs.h. >> >> >> >> --- a/include/linux/romfs_fs.h >> >> +++ b/include/linux/romfs_fs.h >> >> @@ -1,6 +1,9 @@ >> >> __#ifndef __LINUX_ROMFS_FS_H >> >> __#define __LINUX_ROMFS_FS_H >> >> >> >> +#include <linux/types.h> >> >> +#include <linux/fs.h> >> >> + >> >> __/* The basic structures of the romfs filesystem */ >> >> >> >> __#define ROMBSIZE BLOCK_SIZE >> > >> > Better changelogs please. >> > >> > Does this fix any build error? __If so, is that build error present in >> > 2.6.36 or earlier? >> >> headers should include the headers that define types/things that the >> header itself needs > > I take that to mean "no" and "no", hence the fix is not needed in > 2.6.37 and is not needed in -stable.
it's been broken for years, so people have long worked around it. the history is clear that there is no regression. but headers should be correct unto themselves. -mike
| |