Messages in this thread | | | From | "Sosnowski, Maciej" <> | Date | Mon, 22 Nov 2010 16:49:45 +0000 | Subject | RE: [patch v2] dca: remove unneeded NULL check |
| |
Dan Carpenter wrote: > The return here doesn't release the locks or re-enable IRQs. But as > Andrew Morton points out, domain is never NULL. list_first_entry() > essentially never returns NULL and also we already verified that the > list is not empty. > > Signed-off-by: Dan Carpenter <error27@gmail.com> > > diff --git a/drivers/dca/dca-core.c b/drivers/dca/dca-core.c index > b98c676..c461eda 100644 > --- a/drivers/dca/dca-core.c > +++ b/drivers/dca/dca-core.c > @@ -110,8 +110,6 @@ static void unregister_dca_providers(void) > > /* at this point only one domain in the list is expected */ > domain = list_first_entry(&dca_domains, struct dca_domain, node); > - if (!domain) > - return; > > list_for_each_entry_safe(dca, _dca, &domain->dca_providers, node) { > list_del(&dca->node);
Acked-by: Maciej Sosnowski <maciej.sosnowski@intel.com>
| |