Messages in this thread | | | Subject | Re: [PATCH 56/62] iwlwifi: Use static const | From | "Guy, Wey-Yi" <> | Date | Mon, 22 Nov 2010 07:37:03 -0800 |
| |
Hi Joe,
On Sat, 2010-11-20 at 18:38 -0800, Joe Perches wrote: > Using static const generally increases object text and decreases data size. > It also generally decreases overall object size. > > text data bss dec hex filename > 48644 57 12120 60821 ed95 drivers/net/wireless/b43/phy_n.o.new > 48661 57 12120 60838 eda6 drivers/net/wireless/b43/phy_n.o.old > 37906 86 7904 45896 b348 drivers/net/wireless/iwlwifi/iwl-agn-lib.o.new > 37937 86 7904 45927 b367 drivers/net/wireless/iwlwifi/iwl-agn-lib.o.old > 37781 523 6752 45056 b000 drivers/net/wireless/iwlwifi/iwl-3945.o.new > 37781 523 6752 45056 b000 drivers/net/wireless/iwlwifi/iwl-3945.o.old > > Changed b43_nphy_write_clip_detection to take a const u16 * > > Signed-off-by: Joe Perches <joe@perches.com> > ---
I don't see size difference on 3945, otherwise the patch looks ok to me
Wey
| |