lkml.org 
[lkml]   [2010]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BUG?] [Ext4] INFO: suspicious rcu_dereference_check() usage
On Mon, Nov 22, 2010 at 12:39:49AM +0900, Minchan Kim wrote:
>
> I think it's no problem.
>
> That's because migration always holds lock_page on the file page.
> So the page couldn't remove from radix.

It may be "ok" in that it won't cause a race, but it still leaves an
unsightly warning if LOCKDEP is enabled, and LOCKDEP warnings will
cause /proc_lock_stat to be disabled. So I think it still needs to be
fixed by adding rcu_read_lock()/rcu_read_unlock() to
migrate_page_move_mapping().

- Ted


\
 
 \ /
  Last update: 2010-11-21 18:39    [W:0.057 / U:5.892 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site