lkml.org 
[lkml]   [2010]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] vmscan: Make move_active_pages_to_lru more generic
From
Hi Wu,

On Mon, Nov 22, 2010 at 10:36 AM, Wu Fengguang <fengguang.wu@intel.com> wrote:
> On Sun, Nov 21, 2010 at 10:24:56PM +0800, Minchan Kim wrote:
>> Now move_active_pages_to_lru can move pages into active or inactive.
>> if it moves the pages into inactive, it itself can clear PG_acive.
>> It makes the function more generic.
>
> Do you plan to use this "more generic" function? Because the patch in
> itself makes code slightly less efficient. It adds one "if" test, and
> moves one operation into the spin lock.

I tried to use it in my deactivate page series but couldn't use it due
some problem.
So I don't have a plan to use it. It's just my preference(and I hope
others think like me :) )

I hope function itself would be generic and clear because some people
in future might use it and reference it.
If my change makes big cost, I am not against you. otherwise, I hope
move_active_pages_to_lru become self-contained.

>
> Thanks,
> Fengguang
>



--
Kind regards,
Minchan Kim


\
 
 \ /
  Last update: 2010-11-22 02:53    [W:0.050 / U:2.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site