lkml.org 
[lkml]   [2010]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] vmscan: Make move_active_pages_to_lru more generic
On Sun, Nov 21, 2010 at 10:24:56PM +0800, Minchan Kim wrote:
> Now move_active_pages_to_lru can move pages into active or inactive.
> if it moves the pages into inactive, it itself can clear PG_acive.
> It makes the function more generic.

Do you plan to use this "more generic" function? Because the patch in
itself makes code slightly less efficient. It adds one "if" test, and
moves one operation into the spin lock.

Thanks,
Fengguang


\
 
 \ /
  Last update: 2010-11-22 02:39    [W:0.042 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site