lkml.org 
[lkml]   [2010]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] vmscan: Make move_active_pages_to_lru more generic
On 11/21/2010 09:24 AM, Minchan Kim wrote:
> Now move_active_pages_to_lru can move pages into active or inactive.
> if it moves the pages into inactive, it itself can clear PG_acive.
> It makes the function more generic.

> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index aa4f1cb..bd408b3 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1457,6 +1457,10 @@ static void move_active_pages_to_lru(struct zone *zone,
> VM_BUG_ON(PageLRU(page));
> SetPageLRU(page);
>
> + /* we are de-activating */
> + if (!is_active_lru(lru))
> + ClearPageActive(page);
> +

Does that mean we also want code to ensure that pages have
the PG_active bit set when we add them to an active list?

--
All rights reversed


\
 
 \ /
  Last update: 2010-11-21 19:09    [W:0.040 / U:8.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site