lkml.org 
[lkml]   [2010]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCHv4 06/17] pps: convert printk/pr_* to dev_*
    From
    Date
    On Sun, 2010-11-21 at 00:33 +0300, Alexander Gordeev wrote:
    > В Sat, 20 Nov 2010 16:49:40 +0100
    > Rodolfo Giometti <giometti@enneenne.com> пишет:
    > > On Thu, Nov 18, 2010 at 07:00:59PM +0300, Alexander Gordeev wrote:
    > > > Since we now have direct pointers to struct pps_device everywhere it's
    > > > easy to use dev_* functions to print messages instead of plain printks.
    > > > Where dev_* cannot be used printks are converted to pr_*.
    > > > diff --git a/drivers/pps/kapi.c b/drivers/pps/kapi.c
    []
    > > > @@ -80,20 +81,20 @@ struct pps_device *pps_register_source(struct pps_source_info *info,
    > > >
    > > > /* Sanity checks */
    > > > if ((info->mode & default_params) != default_params) {
    > > > - printk(KERN_ERR "pps: %s: unsupported default parameters\n",
    > > > + pr_err("pps: %s: unsupported default parameters\n",
    > > > info->name);

    Perhaps you want to remove the "pps:" prefixes?

    > > > - printk(KERN_ERR "pps: %s: echo function is not defined\n",
    > > > + pr_err("pps: %s: echo function is not defined\n",
    []
    > > > - printk(KERN_ERR "pps: %s: unspecified time format\n",
    > > > + pr_err("pps: %s: unspecified time format\n",
    []
    > > > - printk(KERN_ERR "pps: %s: too many PPS sources in the system\n",
    > > > + pr_err("pps: %s: too many PPS sources in the system\n",
    []
    > > > - printk(KERN_ERR "pps: %s: unable to create char device\n",
    > > > + pr_err("%s: unable to create char device\n",

    It's removed here.

    > > > - printk(KERN_ERR "pps: %s: unable to register source\n", info->name);
    > > > + pr_err("%s: unable to register source\n", info->name);

    and here.


    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-11-20 22:45    [W:0.022 / U:151.528 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site