Messages in this thread | | | Subject | Re: [PATCH] mxcmmc: Add the ability to bind a regulator to manage the MMC card voltage | From | Alberto Panizzo <> | Date | Tue, 02 Nov 2010 11:33:36 +0100 |
| |
On mar, 2010-11-02 at 08:39 +0100, Sascha Hauer wrote: > On Tue, Nov 02, 2010 at 01:05:37AM +0100, Alberto Panizzo wrote: > > This implementation is based on the pxamci.c driver and it will > > be used to support the mx31_3ds machine. > > > > Signed-off-by: Alberto Panizzo <maramaopercheseimorto@gmail.com> > > Looks good to me > > Acked-by: Sascha Hauer <s.hauer@pengutronix.de>
Tks Sascha, the only difference between the pxa implementations is in this part:
> > +static inline void mxcmci_set_power(struct mxcmci_host *host, unsigned int vdd) > > +{ > > +#ifdef CONFIG_REGULATOR > > + if (host->vcc) > > + mmc_regulator_set_ocr(host->vcc, vdd); > > +#endif > > + if (host->pdata && host->pdata->setpower) > > + host->pdata->setpower(mmc_dev(host->mmc), vdd); > > +} > > +
The original one have this test: if (!host->vcc && host->pdata && host->pdata->setpower) host->pdata->setpower(mmc_dev(host->mmc), vdd);
But removing it, we are able to add further action than only powering with the right voltage the mmc card. In the case of the mx31_3ds we are able to enable the external hardware buffer only when it is really needed.
-- Alberto!
Be Persistent! - Greg Kroah-Hartman (FOSDEM 2010)
| |