Messages in this thread | | | Date | Tue, 2 Nov 2010 12:04:56 -0400 | Subject | Re: drivers/media/IR/ir-keytable.c::ir_getkeycode - 'retval' may be used uninitialized | From | Jarod Wilson <> |
| |
On Sun, Oct 31, 2010 at 6:18 PM, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > On Sunday, October 31, 2010 10:51:21 am Stefan Richter wrote: >> Commit 9f470095068e "Input: media/IR - switch to using new keycode >> interface" added the following build warning: >> >> drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode': >> drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used uninitialized in this function >> >> It is due to an actual bug but I don't know the fix. >> > > The patch below should fix it. I wonder if Linus released -rc1 yet...
Looks like it missed rc1.
> Input: ir-keytable - fix uninitialized variable warning > > From: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > We were forgetting to set up proper return value in success path causing > ir_getkeycode() to fail intermittently: > > drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode': > drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used > uninitialized in this function > > Reported-by: Stefan Richter <stefanr@s5r6.in-berlin.de> > Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Acked-by: Jarod Wilson <jarod@redhat.com>
-- Jarod Wilson jarod@wilsonet.com
| |