lkml.org 
[lkml]   [2010]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[07/66] pcmcia: synclink_cs: fix information leak to userland
    2.6.36-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Vasiliy Kulikov <segooon@gmail.com>

    commit 5b917a1420d3d1a9c8da49fb0090692dc9aaee86 upstream.

    Structure new_line is copied to userland with some padding fields unitialized.
    It leads to leaking of stack memory.

    Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
    Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/char/pcmcia/synclink_cs.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/drivers/char/pcmcia/synclink_cs.c
    +++ b/drivers/char/pcmcia/synclink_cs.c
    @@ -4127,6 +4127,8 @@ static int hdlcdev_ioctl(struct net_devi
    if (cmd != SIOCWANDEV)
    return hdlc_ioctl(dev, ifr, cmd);

    + memset(&new_line, 0, size);
    +
    switch(ifr->ifr_settings.type) {
    case IF_GET_IFACE: /* return current sync_serial_settings */




    \
     
     \ /
      Last update: 2010-11-19 23:21    [W:0.018 / U:1.108 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site