lkml.org 
[lkml]   [2010]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[62/66] Fixed Regression in NFS Direct I/O path
    2.6.36-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Steve Dickson <steved@redhat.com>

    commit 568a810d7edd58bd505222dd1c7e48895532290b upstream.

    A typo, introduced by commit f11ac8db, in the nfs_direct_write()
    routine causes writes with O_DIRECT set to fail with a ENOMEM error.

    Found-by: Jeff Layton <jlayton@redhat.com>
    Signed-off-by: Steve Dickson <steved@redhat.com>
    Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    fs/nfs/direct.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/nfs/direct.c
    +++ b/fs/nfs/direct.c
    @@ -873,7 +873,7 @@ static ssize_t nfs_direct_write(struct k
    dreq->inode = inode;
    dreq->ctx = get_nfs_open_context(nfs_file_open_context(iocb->ki_filp));
    dreq->l_ctx = nfs_get_lock_context(dreq->ctx);
    - if (dreq->l_ctx != NULL)
    + if (dreq->l_ctx == NULL)
    goto out_release;
    if (!is_sync_kiocb(iocb))
    dreq->iocb = iocb;



    \
     
     \ /
      Last update: 2010-11-19 23:09    [W:0.043 / U:117.984 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site