[lkml]   [2010]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[78/82] secmark: do not return early if there was no error
2.6.35-stable review patch.  If anyone has any objections, please let us know.


From: Eric Paris <>

commit 15714f7b58011cf3948cab2988abea560240c74f upstream.

Commit 4a5a5c73 attempted to pass decent error messages back to userspace for
netfilter errors. In xt_SECMARK.c however the patch screwed up and returned
on 0 (aka no error) early and didn't finish setting up secmark. This results
in a kernel BUG if you use SECMARK.

Signed-off-by: Eric Paris <>
Acked-by: Paul Moore <>
Signed-off-by: James Morris <>
Signed-off-by: Greg Kroah-Hartman <>

net/netfilter/xt_SECMARK.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/net/netfilter/xt_SECMARK.c
+++ b/net/netfilter/xt_SECMARK.c
@@ -101,7 +101,7 @@ static int secmark_tg_check(const struct
switch (info->mode) {
err = checkentry_selinux(info);
- if (err <= 0)
+ if (err)
return err;

 \ /
  Last update: 2010-11-19 23:05    [W:0.024 / U:19.980 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site