lkml.org 
[lkml]   [2010]   [Nov]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: Re: [PATCH] ARM: l2x0: Check the correct address range
On Fri, 2010-11-19 at 11:08 +0000, Catalin Marinas wrote:
> On 19 November 2010 01:40, Kyungmin Park <kmpark@infradead.org> wrote:
> > From: Boojin Kim <boojin.kim@samsung.com>
> >
> > When flush or clean the 1MiB, it doesn't flush or clean all since it doesn't check the correct address. So Check the correct address range.
>
> This line is very long.
>
> The patch looks fine otherwise. I think the optimal value would be
> smaller than the whole cache size but it depends on many things.

Would it be a good idea to kick in a per-SoC threshold value into
the l2x0 range clean function, such that if the range exceed this
specific threshold it cleans all of it? That way it'd be possible
to optimize for each SoC quite easily.

I've heard that these things may even depend on OPPs etc so it may
even be some dynamic value...

Yours,
Linus Walleij
[unhandled content-type:application/ms-tnef]
\
 
 \ /
  Last update: 2010-11-19 22:53    [W:0.039 / U:2.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site