Messages in this thread Patch in this message | | | Date | Fri, 19 Nov 2010 13:30:46 -0800 | From | Greg KH <> | Subject | [1/5] pcmcia: synclink_cs: fix information leak to userland |
| |
2.6.27-stable review patch. If anyone has any objections, please let us know.
------------------
From: Vasiliy Kulikov <segooon@gmail.com>
commit 5b917a1420d3d1a9c8da49fb0090692dc9aaee86 upstream.
Structure new_line is copied to userland with some padding fields unitialized. It leads to leaking of stack memory.
Signed-off-by: Vasiliy Kulikov <segooon@gmail.com> Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- drivers/char/pcmcia/synclink_cs.c | 2 ++ 1 file changed, 2 insertions(+)
--- a/drivers/char/pcmcia/synclink_cs.c +++ b/drivers/char/pcmcia/synclink_cs.c @@ -4287,6 +4287,8 @@ static int hdlcdev_ioctl(struct net_devi if (cmd != SIOCWANDEV) return hdlc_ioctl(dev, ifr, cmd); + memset(&new_line, 0, size); + switch(ifr->ifr_settings.type) { case IF_GET_IFACE: /* return current sync_serial_settings */
| |