Messages in this thread | | | Subject | Re: [PATCH v1.4 3/5] key: add tpm_send command | From | David Safford <> | Date | Fri, 19 Nov 2010 11:04:56 -0500 |
| |
On Fri, 2010-11-19 at 15:45 +0000, David Howells wrote: > Mimi Zohar <zohar@linux.vnet.ibm.com> wrote: > > > +int tpm_send(u32 chip_num, void *cmd, int buflen) > > I'd recommend size_t for buflen; apart from that: > > Acked-by: David Howells <dhowells@redhat.com>
right - that would be better.
Currently transmit_command() in tpm.c expects an int, but it changes it to size_t for the actual tpm_transmit(). We will work with Rajiv to do a cleanup, as this touches a number of calls.
thanks! dave
| |