lkml.org 
[lkml]   [2010]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] qlge: Fix incorrect usage of module parameters and netdev msg level
    Driver appears to be mistaking the permission field with default value
    in the case of debug and qlge_irq_type.

    Driver is also passing debug as a bitmask into netif_msg_init()
    which wants a number of bits. Ron Mercer suggests we should
    change this to pass in -1 so the defaults get used instead,
    which makes the default much less verbose.

    Signed-off-by: Milton Miller <miltonm@bga.com>
    Signed-off-by: Sonny Rao <sonnyrao@linux.vnet.ibm.com>
    ---

    v2: Changed debug to be -1 and updated changelog

    drivers/net/qlge/qlge_main.c | 6 +++---
    1 files changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c
    index d9a7626..66878bb 100644
    --- a/drivers/net/qlge/qlge_main.c
    +++ b/drivers/net/qlge/qlge_main.c
    @@ -62,15 +62,15 @@ static const u32 default_msg =
    /* NETIF_MSG_PKTDATA | */
    NETIF_MSG_HW | NETIF_MSG_WOL | 0;

    -static int debug = 0x00007fff; /* defaults above */
    -module_param(debug, int, 0);
    +static int debug = -1; /* defaults above */
    +module_param(debug, int, 0664);
    MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)");

    #define MSIX_IRQ 0
    #define MSI_IRQ 1
    #define LEG_IRQ 2
    static int qlge_irq_type = MSIX_IRQ;
    -module_param(qlge_irq_type, int, MSIX_IRQ);
    +module_param(qlge_irq_type, int, 0664);
    MODULE_PARM_DESC(qlge_irq_type, "0 = MSI-X, 1 = MSI, 2 = Legacy.");

    static int qlge_mpi_coredump;

    \
     
     \ /
      Last update: 2010-11-18 22:53    [W:0.019 / U:0.060 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site