lkml.org 
[lkml]   [2010]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 5ada28bf76752 causes compilation error if !CONFIG_LEDS_CLASS
    On Tue 16-11-10 17:41:33, Berg, Johannes wrote:
    > > it seems that your patch (5ada28bf76752e33dce3d807bf0dfbe6d1b943ad)
    > > causes the following compilatation error:
    > > LD .tmp_vmlinux1
    > > drivers/built-in.o: In function `led_trigger_set':
    > > drivers/leds/led-triggers.c:116: undefined reference to
    > > `led_brightness_set'
    > > make[1]: *** [.tmp_vmlinux1] Error 1
    > >
    > > AFAICS, led_brightness_set is defined in drivers/leds/led-class.c which
    > > is compiled only if CONFIG_LEDS_CLASS is configured which is not my
    > > case (after make oldconfig with all default values from 37-rc1).
    > >
    > > I am not sure what is the right solution whether CONFIG_LEDS_TRIGGERS
    > > should depend on CONFIG_LEDS_CLASS or the patch should be reverted.
    > >
    > > My config is attached, if somebody need it.
    >
    > Hmm, we did find that, and I made a patch to fix up the Kconfig, that apparently hasn't made it in? Bit confused now.

    Does this mean that I should enable CONFIG_LEDS_CLASS to work around the
    issue for this moment?

    >
    > johannes
    > --------------------------------------------------------------------------------------
    > Intel GmbH
    > Dornacher Strasse 1
    > 85622 Feldkirchen/Muenchen, Deutschland
    > Sitz der Gesellschaft: Feldkirchen bei Muenchen
    > Geschaeftsfuehrer: Douglas Lusk, Peter Gleissner, Hannes Schwaderer
    > Registergericht: Muenchen HRB 47456
    > Ust.-IdNr./VAT Registration No.: DE129385895
    > Citibank Frankfurt a.M. (BLZ 502 109 00) 600119052
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    > Please read the FAQ at http://www.tux.org/lkml/

    --
    Michal Hocko
    L3 team
    SUSE LINUX s.r.o.
    Lihovarska 1060/12
    190 00 Praha 9
    Czech Republic


    \
     
     \ /
      Last update: 2010-11-18 09:27    [W:0.024 / U:149.512 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site