Messages in this thread | | | Date | Thu, 18 Nov 2010 13:06:53 -0800 | From | David Daney <> | Subject | Re: [PATCH 2/2] phylib: Add support for Marvell 88E1149R devices. |
| |
On 11/18/2010 12:44 PM, Grant Likely wrote: > On Thu, Nov 18, 2010 at 11:46:16AM -0800, David Miller wrote: >> From: David Daney<ddaney@caviumnetworks.com> >> Date: Wed, 17 Nov 2010 15:54:31 -0800 >> >>> The 88E1149R is 10/100/1000 quad-gigabit Ethernet PHY. The >>> .config_aneg function can be shared with 88E1118, but it needs its own >>> .config_init. >>> >>> Signed-off-by: David Daney<ddaney@caviumnetworks.com> >> >> Please resend this when you've respun patch #1 based upon the feedback >> you've been given. > > It looks to me that this patch has no dependencies on the first patch. > ddaney; what say you? >
It calls the marvell_of_reg_init() function introduced in the first patch. Reordering the patches would be possible, but since nobody else has cared enough to add 88E1149R support, it shouldn't affect anyone be me.
I arbitrarily ordered it this way. If davem wishes, I could re-order the patches and 88E1149R could be merged before the device tree part.
David Daney
| |